Create Patient Service and Implement CRUD operations #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show new covered files 🐣
Test suite run success89 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 957a8ab |
elsaperelli
approved these changes
Jun 19, 2024
hossenlopp
requested changes
Jun 19, 2024
There was a problem hiding this comment.
The listing of all patients is returning a JSON Array this should be a searchset Bundle instead. See https://hl7.org/fhir/R4/http.html#search for more info.
Additionally we should have the internal mongo _ids projected out of the responses.
…ge to response to a searchset.
|
I made the requested changes. One potentially weird thing that I did was call |
elsaperelli
requested changes
Jun 19, 2024
elsaperelli
approved these changes
Jun 20, 2024
hossenlopp
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds endpoints to the bulk-export-server to handle operations related to Patients. Adds operations to create, get, update and delete patients on the server. This PR also adds
Groupdelete endpoint.[host]/Patientand[host]/Groupnow correctly return asearchsetas per fhir spec, https://hl7.org/fhir/R4/http.html#search.JIRA Issue
New behavior
bulk-export-server now has CRUD operations for Patients
GET:[host]/PatientGET:[host]/Patient/[patientId]POST:[host]/PatientPUT:[host]/Patient/[patientID]DELETE:[host]/Patient/[patientID]Now has new delete operation for Group
DELETE:[host]/Group/[groupID]Endpoints that find multiple Patients or Groups from the server,
GET:[host]/PatientandGET:[host]/Group, now return a searchset object instead of a json list of fhir Patient or Group objects.Code changes
.eslintrc.jsonand.prettierignorewere changed to addecqm-content-r4-2021to the excluded folders because they were causing warnings with eslint and prettier.src/server/app.jswas changed to add the new patient endpoints and new group endpoint to the server.src/services/group.service.js: updated some comments to be more specific, wrapped the /Group get endpoint in a search set object, added new function for DELETE endpoint.src/services/patient.service.jswas created to implement functions that will interact with the database to fulfill the CRUD operations requested when a user accesses the endpoints for Patients.test/fixtures/updatedTestPatient.jsonwas created to test thePUTendpoint.test/services/patient.service.test.jsare tests for the patient.service.js operations that follows closely from thegroup.service.test.jsfile.src/util/bundleUtils.js: created to generate the searchset bundle object that wraps the response from the server for the /Patient and /Group endpoints.src/util/mongo.controller.js: added a default projection to filter out mongo-generated ids from the server's responses to all operations.test/services/group.service.test.js: changed /Group test to interact with new searchset response from serverTesting guidance
npm run check